-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(layout): simplify and doc split() #405
Conversation
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 85.36% 86.09% +0.73%
==========================================
Files 40 40
Lines 8853 9221 +368
==========================================
+ Hits 7557 7939 +382
+ Misses 1296 1282 -14
|
Pinging @hasezoey for 👀 and 💭 on this. |
Thanks for the review comments @hasezoey. I've updated the comments to better explain the testing approach (and removed a couple of comments that were accidentally left in while testing the rounding fix) |
f31f8c9
to
4834f05
Compare
Incoming push makes Element one dimensional (just I also moved the tests prior to the refactor commit to show that they apply equally to the existing code and the refactored code. |
Sorry about the staged second round of comments! This looks great now btw! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is mainly a reduction in density of the code with a goal of improving mainatainability so that the algorithm is clear.
This is mainly a reduction in density of the code with a goal of
improving mainatainability so that the algorithm is clear.
(Testing - the layout example renders the same)