refactor(layout): change "split"'s vars to be of known labeled values #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 85.37% 85.36% -0.02%
==========================================
Files 40 40
Lines 8875 8867 -8
==========================================
- Hits 7577 7569 -8
Misses 1298 1298
|
joshka
reviewed
Aug 13, 2023
Removes some unnecessary code and makes the function more readable. Instead of creating a temporary result and mutating it, we just create the result directly from the list of changes.
joshka
force-pushed
the
knownAttributes
branch
from
9a53349 to
0fa4b77
Compare
|
Rebased on main, squashed and reworded the commit. |
joshka
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all values for the
layout'ssplit'svarsvalue to be known and labeled, this changes the code to be more readable and defines the values in a common place, also removing a extra match arm