-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expand serde attributes for TestBuffer
#389
Conversation
68d2cf7
to
1054317
Compare
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 86.41% 86.38% -0.04%
==========================================
Files 40 40
Lines 9432 9436 +4
==========================================
Hits 8151 8151
- Misses 1281 1285 +4
|
I'm curious what you're using this for. Do you think this needs unit / integ tests? It would help catch any serialization breaking changes if these were tested. |
I am not quite sure how to test the serialization without bringing in another dependency. I will look further into it. I am in the process of prototyping a snapshot testing helper, specifically for ratatui. |
Cool stuff! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big deal on the tests for this - unless there's a simple way to do this. None of our other serializable types have tests right now.
Needs to be rebased before merging. Can you please take a look? |
1054317
to
e66623e
Compare
This makes it possible to deserialize/serialize the whole test buffer with the
serde
feature.