test(sparkline): added benchmark #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added benchmark for the `sparkline` widget testing a basic render with different amout of data
Valentin271
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 40 40
Lines 8683 8683
=======================================
Hits 7383 7383
Misses 1300 1300 |
joshka
approved these changes
Aug 7, 2023
kdheepak
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds benchmark for the
sparklinewidget testing a basic render with different amounts of data.Reports
The
sparklinerenders only the values that can fit in the buffer width (200 for this test), above that amount, there is almost no difference in the performance.