-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): upgrade crossterm to 0.27 #380
Conversation
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
==========================================
+ Coverage 84.99% 85.02% +0.02%
==========================================
Files 40 40
Lines 8686 8683 -3
==========================================
Hits 7383 7383
+ Misses 1303 1300 -3
|
IMO it is a breaking change because ratatui requires us to install crossterm separately for input handling. Some extensions will break too. |
You should be able to have And there shouldn't be conflicting dependencies since Can you show me an example of an extension that will break as a result of this change? I am happy to mark this as a breaking change if that is the consensus. |
What should we do about doc comments / readme for this? Make the change now or leave it until we release? I wonder how many people use the version number from the github readme. |
Thank you, that is a good point. I will update the references as well.
Since the version number is only in a doc comment I don't think it matters in this case. Edit: |
b905805
to
e7a7ac3
Compare
Cool... I have tested with tui-input. After a |
Thank you for testing it! |
I remember Florian creating releases for only crossterm updates but I'm not sure if it is because he wanted to make the upgrade easier for the users or not. Just my 2 cents. |
I just looked through the releases of tui-rs. |
Changelog
Upgrade
crossterm
tov0.27
.I don't think this is a breaking change, since the
crossterm
internals aren't exposed, is that correct?