-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(list): Added benchmarks #377
Conversation
Codecov Report
@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 84.99% 84.99%
=======================================
Files 40 40
Lines 8686 8686
=======================================
Hits 7383 7383
Misses 1303 1303 |
f8b7259
to
430dad5
Compare
Added benchmarks for the list widget (render and render half scrolled)
430dad5
to
caccb42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This is great.
I added benchmarks for the
list
widget :Chose 16284 as the highest number of lines so we can see the three tests on the graph.
I tried benchmarking the
new
operation but I think it is not necessary as it only involves copying/moving.Some benchmarks
Figure 1: Render time relative to number of lines
Figure 2: Halfway scrolled render time relative to number of lines
Figure 3: Render vs halfway scrolled render
The number of lines impact the performances (probably because of memory usage?) but where the list is rendered (the
offset
) doesn't seem to.Relates to #137