fix(block): Fixed title_style not rendered #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentin271
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
Valentin271
force-pushed
the
main
branch
2 times, most recently
from
3ccc39f to
1922b9e
Compare
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 84.76% 84.99% +0.23%
==========================================
Files 40 40
Lines 8603 8686 +83
==========================================
+ Hits 7292 7383 +91
+ Misses 1311 1303 -8
|
Valentin271
changed the title
joshka
approved these changes
Aug 4, 2023
|
I merged #351 now, and took a look at this visually and it acts as expected.: |
joshka
approved these changes
Aug 4, 2023
|
Merging this even though checks are failing as the failures are due to the MSRV issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #349 the easy way (see issue). I think the complex fix requires another separate PR.
I added a unit test and made sure it didn't pass prior to this modification. I added a lot of test cases because there are three separate places where this bug can occur.
I didn't change the corresponding example to demonstrate the behavior as there is already an opened PR that will likely be merged.
I didn't want to create a new spans (or lines) because in the future they might contain more than just
contentandstyleand this would lead to some half cloned spans. Thus I preferred cloning and modifying them locally.