chore(toolchain)!: bump msrv to 1.67

[a-kenji]

This updates the msrv to 1.67.

Because an optional dependency of ratatui requires it.

Alternatives: Choose to not bump the versions for optional dependencies, or pin the time version to the latest version that supports 1.65

[TieWay59]

LGTM. Many CI-checks failed on this.

[orhun]

Hey, what is the exact reason for this bump? i.e. which optional dependency is that? I'm asking because I'm a proponent of avoiding MSRV bump as much as possible.

[a-kenji]

It is the current reason that the ci for 1.65 fails on some current PR's.

error: package time v0.3.24 cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.65.0

I believe it is the optional calendar feature that pulls this dependency in.

[joshka]

The N-2 policy change for the time crate is documented at time-rs/time#535.. Having read some of that thread (but not all, it's long), the arguments sound reasonable and I think we shouldn't avoid MSRV bumps.

I'd prefer to avoid the pin time approach (as that probably requires extra manual effort to keep abreast of any CVEs etc.), and so that the only other approach is to remove the calendar widget from the repo. I don't think that's reasonable either.

I'm approving this, but won't merge as I think it's worth hearing @orhun's perspective on this before merging.

[orhun]

Sounds reasonable, let's bump it up! 🆙

[codecov]

Codecov Report

Merging #361 (b0205e6) into main (440f62f) will increase coverage by 0.23%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   84.76%   84.99%   +0.23%     
==========================================
  Files          40       40              
  Lines        8603     8686      +83     
==========================================
+ Hits         7292     7383      +91     
+ Misses       1311     1303       -8     

see 2 files with indirect coverage changes

[Valentin271]

I think "Since version 0.21.0" should be updated to 0.23.0 as the MSRV will be bumped in the next release.

[orhun]

Ah, right. Feel free to submit a PR!

[Valentin271]

Done at #369 :)