fix(cargo): adjust minimum paste version #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndd7xv
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
joshka
approved these changes
Jul 26, 2023
|
Thanks for the fix. https://github.com/ndd7xv/heh looks pretty neat |
ratatui is using features that are currently only available in paste 1.0.2; specifying the minimum version to be 1.0 will consequently cause a compilation error if cargo is only able to use a version less than 1.0.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all wanted to say that I love ratatui/tui and appreciate the continued maintenance of it :)
I ran into a CI issue when trying to release a new version of my terminal hex editor that uses ratatui. The job essentially checks if the minimal versions specified in the
Cargo.tomlare able to compile the rust project. With how this currently works,-Z minimal-versionscurrently checks transitive dependencies, and I've identified the source of the error to be that the minimum required version ofpasteshould actually be1.0.2instead of1.0.This isn't really a problem, considering that the possibility of Cargo using a paste version
1.0.0or1.0.1to build this library on other peoples machines is not that high. Other transitive dependencies that ratatui relies on also have this "problem," but for my use case - since I only use the crossterm feature - makes my job go green.(In the future, I'll modify my job to run with
-Zdirect-minimal-versions, which would also make the job go green)