-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): Add color and modifiers examples #345
Conversation
8f62e5e
to
01ed73c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the impl Display for Color
part of this PR is great, and the example you've added is good for that. I think most of my comments are about improving the screenshot for making it easier for beginners to grok and I imagine we can lump those changes into a separate discussion / PR where we modify all the examples.
Ignore the push just now - I just saw the comments. |
4e316de
to
fc01253
Compare
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 85.02% 85.10% +0.07%
==========================================
Files 40 40
Lines 8683 8727 +44
==========================================
+ Hits 7383 7427 +44
Misses 1300 1300
|
I split the style example in two (colors and modifiers) and addressed the comments. I added a color to the example to make this useful to see non-grayscale interactions. |
That visually looks awesome now! Is the RGB section missing a section title? |
Nope - it's all indexed colors 0-255. The gaps are there because there's sort of 3 groups of colors. |
Bumped this with some light changes:
|
Rebased on main to check that the codecov setup should ignore changes to examples. |
Rebased on main and added tests for |
I have a minor preference for using reset for the background. The top part of the screenshot is the PR unchanged: And the bottom is when I use Reset for the indexed part of the demo. This is with this colorscheme: https://github.com/catppuccin/iterm |
How does the VHS output look? |
The VHS output should remain unchanged compared to your screenshot, right? I can try it when I'm back at my personal computer. I think the screenshot looks great if people are just viewing it online (probably like 95% of folk). There's probably a handful of people that might try to run it. I don't think we should optimize for that use case, but if it is low effort it would be nice to accommodate that as well. |
The intent of these examples is to show the available colors and modifiers. - added impl Display for Color ![colors](https://vhs.charm.sh/vhs-2ZCqYbTbXAaASncUeWkt1z.gif) ![modifiers](https://vhs.charm.sh/vhs-2ovGBz5l3tfRGdZ7FCw0am.gif)
Neat! |
Thanks for the review @kdheepak :) |
The intent of these examples is to show the available colors and
modifiers.