fix(barchart): empty groups causes panic #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unlikely to happen, since nobody wants to add an empty group. Even we fix the panic, things will not render correctly. So it is better to just not add them to the BarChart. Signed-off-by: Ben Fekih, Hichem <[email protected]>
karthago1
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles and
joshka
as code owners
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 85.05% 85.08% +0.03%
==========================================
Files 40 40
Lines 8590 8608 +18
==========================================
+ Hits 7306 7324 +18
Misses 1284 1284
|
orhun
approved these changes
Jul 19, 2023
joshka
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unlikely to happen, since nobody wants to add an empty group.
Even if we fix the panic, things will not render correctly. So it is better to just not add them at all.