fix(scrollbar)!: move symbols and set to symbols module #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit and
sophacles
as code owners
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 40 40
Lines 8590 8590
=======================================
Hits 7306 7306
Misses 1284 1284
|
The symbols and sets are moved from `widgets::scrollbar` to `symbols::scrollbar`. This makes it consistent with the other symbol sets and allows us to make the scrollbar module private rather than re-exporting it. BREAKING CHANGE: The symbols are now in the `symbols` module. To update your code, add an import for `ratatui::symbols::scrollbar::*` (or the specific symbols you need). The scrollbar module is no longer public. To update your code, remove any `widgets::scrollbar` imports and replace it with `ratatui::widgets::Scrollbar`.
joshka
force-pushed
the
fix-scrollbar-symbols
branch
from
85018c2 to
61493c5
Compare
kdheepak
reviewed
Jul 17, 2023
|
nit: commit message should be |
joshka
changed the title
Fixed :) |
kdheepak
approved these changes
Jul 24, 2023
orhun
approved these changes
Jul 26, 2023
kdheepak
added
the
Type: Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it consistent with the other symbol sets
BREAKING CHANGE: The symbols are now in the
symbolsmodule. To updateyour code, add an import for
ratatui::symbols::scrollbar::*(or thespecific symbols you need).