-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve scrollbar doc comment #329
Conversation
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 40 40
Lines 8590 8590
=======================================
Hits 7306 7306
Misses 1284 1284
|
Actually that highlights something for me. That title should show up in the one line description of the struct, but it doesn't because it shows up in the re-exports because the scrollbar module is public. For consistency it shouldn't actually be public, but that required moving the sets. PR for that incoming. There should still be a one line description of the struct though, so just drop the tui-rs part. |
Good catch! I changed the title to be in line with existing widget titles. |
Are you able to setup commit signing? https://docs.github.com/articles/about-gpg/ |
Head branch was pushed to by a user without write access
Thanks :) Merged! |
I find the title is not really needed for the doc comment.
Alternative:
Rename
tui-rs
toratatui
in the title, but I find that this is not needed.