feat(barchart): Add direction attribute. (horizontal bars support)

[karthago1]

Fixes #321

this patch introduces new function direction to allow the barchart to render the bars horizontally.

Note: when direction is set to Direction::Horizontal the function Bar::label() is useless, because the bar label is nowhere printed.

any suggestion how to make the horizontal bar look better?

The bar's value_text is rendered using 2 styles (value_style and the bar_style). Reason: see the following image 😄

[codecov]

Codecov Report

Merging #325 (4de7ecb) into main (a937500) will increase coverage by 0.33%.
The diff coverage is 99.34%.

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   87.08%   87.41%   +0.33%     
==========================================
  Files          40       40              
  Lines        9822    10096     +274     
==========================================
+ Hits         8553     8825     +272     
- Misses       1269     1271       +2     

Files Changed	Coverage Δ
src/widgets/barchart/bar.rs	98.86% <97.14%> (-1.14%)	⬇️
src/widgets/barchart/mod.rs	92.70% <99.61%> (+2.72%)	⬆️
src/widgets/barchart/bar_group.rs	100.00% <100.00%> (ø)

[kdheepak]

Thanks for the PR! Horizontal bar charts look great.

It looks like there's a merge conflict in one of the tests. Would you be able to address that?

[ChiaoTeo]

nice pr, hope merge

[karthago1]

@kdheepak done

[joshka]

This definitely is something that will be useful. This needs some docs about how it works and some more detailed testing. There's a couple of places where I'm not sure what the behavior should be, so I'm not sure if it's a bug or an non-intuitive feature that you've considered.

[joshka]

A couple of small typos, but generally looks good to me. If you can get these fixed up in the next few days this should make the 0.23 release.

I'd still query whether bottom to top rendering is the correct approach, but happy to take that as a future PR if needed.

[karthago1]

I'd still query whether bottom to top rendering is the correct approach, but happy to take that as a future PR if needed.

@joshka I don't care much. I slightly like printing from the bottom. here I made a comparison. It will be nice if you choose, which one looks better? (it will not require much time changing it)

top: (ignore the misplaced group labels)

(here we should maybe move the legend to the bottom )

botttom:

[karthago1]

or maybe let's do in future PR, as you mentioned. maybe we make it configurable. Variable name would be layout_direction or something similar

[joshka]

or maybe let's do in future PR, as you mentioned. maybe we make it configurable. Variable name would be layout_direction or something similar

Yep that's a good way to handle it

[joshka]

Let's go top down for the first release and add another property in sometime soon in a .1 release?

[karthago1]

Let's go top down for the first release and add another property in sometime soon in a .1 release?

ok fine.

[karthago1]

@joshka done. Now it looks like the following:

[joshka]

LGTM. Thanks again for the PR and for your patience sticking with it to get this reviewed and merged.

[joshka]

@ratatui-org/core can someone please take a second review on this?

[joshka]

Merging! Thanks @karthago1 and @kdheepak for the review