Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo make test-termion, instead of cargo make test
Fixes:
Second commit simplifies Makefile.toml to use platform overrides for windows to avoid termion, and makes the backend choice a parameter for tasks that actually need it (e.g.
cargo make test-backend termion
is now possible). Where useful, the makefile now builds features together, rather than separately. All tasks now check all features rather than some skipping the calendar, etc.Third commit fixes an existing error in the termwiz doc tests that this hightlights (was not previously tested as the previous doc tests didn't check all backends)
Performance
Review notes