-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(color): parse more color formats and add docs #306
Conversation
Have you considered adding test cases for the invalid color formats as well? |
@orhun there are existing tests for the invalid formats - am I misunderstanding what you're asking for here? |
Everything is okay as far as we cover these changes I think: |
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 83.11% 83.21% +0.10%
==========================================
Files 37 37
Lines 7717 7764 +47
==========================================
+ Hits 6414 6461 +47
Misses 1303 1303
|
Force push updates the tests to cover more happy paths and a few useful error paths, and moves the aliases out of the match into the replacements only. |
Fixes #305