-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): Add examples readme with gifs #303
Conversation
Codecov Report
@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 40 40
Lines 8590 8590
=======================================
Hits 7306 7306
Misses 1284 1284 |
Hey, what else is needed to be done here? Do you want me to update the workflow to add |
Note the TODOs in the doc. I haven't had a chance to dig into why some of the problems are happening (our side vs vhs side) |
In Block.rs, the entire block background should be green and the top two blocks should render similar widths: Popup has an issue rendering the background: Perhaps it would be sufficient to just note that there are rendering issues with VHS (or rewrite the examples to avoid the issues). @orhun given that you are not seeing the same issues, It's possible that there's some sort of difference in rendering on a mac vs on a linux machine due to tty differences and installed fonts - so I'll check there to compare. |
Yeah, it is likely that those problems are mostly about |
Fixed block, layout and table by changing the examples a bit and updated the README with the new gifs. |
6fda2b8
to
d2b11b1
Compare
|
@joshka Should I add the |
Let's hold off on that for now. It only handles the generate part, not the publishing part, so if we wanted to fully automate the updating of the readme that might be a little difficult. |
|
This commit adds a readme to the examples directory with gifs of each example. This should make it easier to see what each example does without having to run it. I modified the examples to fit better in the gifs. Mostly this was just removing the margins, but for the block example I cleaned up the code a bit to make it more readable and changed it so the background bug is not triggered. For the table example, the combination of Min, Length, and Percent constraints was causing the table to panic when the terminal was too small. I changed the example to use the Max constraint instead of the Length constraint. The layout example now shows information about how the layout is constrained on each block (which is now a paragraph with a block).
This commit adds a readme to the examples directory with gifs of each
example. This should make it easier to see what each example does
without having to run it.
I modified the examples to fit better in the gifs. Mostly this was just
removing the margins, but for the block example I cleaned up the code a
bit to make it more readable.
NOTE!!!!
There are some problems with rendering over ssh, which are not yet resolved. These are noted in the README file. It's possible that these problems are related to #298.
There is a github action that can automatically run VHS as part of a CI process - which would be possibly useful to keep things up to date. https://github.com/charmbracelet/vhs-action