test(list): add characterization tests for list #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2023
|
Would you mind rebasing against main now that #161 is merged? Nothing in here is objectionable, just not sure what's different from main now. |
- also adds builder methods on list state to make it easy to construct a list state with selected and offset as a one-liner. Uses `with_` as the prefix for these methods as the selected method currently acts as a getter rather than a builder. - cargo tarpaulin suggests only two lines are not covered (the two match patterns of the self.start_corner match 223 and 227). the body of these lines is covered, so this is probably 100% coverage.
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a list state with selected and offset as a one-liner. Uses
with_asthe prefix for these methods as the selected method currently acts as
a getter rather than a builder.
match patterns of the self.start_corner match 223 and 227).
the body of these lines is covered, so this is probably 100%
Contextually, this PR is about putting in place some tests for the list widget so that we can easily refactor some of the complexity of the methods to be easy to read and maintain.
Note: this sits on #161 which is not yet merged, so ignore the changes to buffer / sparkline for now.