Fix Materials.cc when scaling scint pdf #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When transforming a ratdb entry describing the scintillation or wavelength shifting pdf as a function of wavelength to energy for sampling, the jacobian element hc/E^2 was omitted causing there to be an unphysical distortion in the output spectrum. This transformation is now implemented
|
As discussed in Slack, the correct approach here is indeed to use the |
|
Yes, after closer inspection this is not the correct way to handle this. Fixing this quirk will take a bit more effort as I have now mentioned in the parent issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141. This only applies the Jacobian element to optical ratdb entries with the 'wavelength' key option specified (wavelength_opt == 1). The 'dy_dwavelength' keyword (wavelength_opt == 2) will need a closer look as I am unfamiliar with what y stands for in this context.
EOS_ratpac_jacobian.pdf