Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RaspiBlitz: 1.9.0 WebUI: 1.1.0 LNBits onion url misformed #630

Closed
jalbstmeijer opened this issue Jun 24, 2023 · 4 comments · Fixed by #647
Closed

RaspiBlitz: 1.9.0 WebUI: 1.1.0 LNBits onion url misformed #630

jalbstmeijer opened this issue Jun 24, 2023 · 4 comments · Fixed by #647
Assignees
Labels
check Issues to be read / refined

Comments

@jalbstmeijer
Copy link

When on the onion url of RaspiBlitz, LNBits is linked as https://{raspiublitz_url}.onion/{lnbits_url}.onion instead of http://{lnbits_url}.onion

@jalbstmeijer jalbstmeijer added the check Issues to be read / refined label Jun 24, 2023
@cstenglein
Copy link
Collaborator

cstenglein commented Jul 29, 2023

@rootzoll Looks at first look like the wrong url is in redis

For my install it looks the same in the installed_app_status message:

  {
    "id": "lnbits",
    "version": "0.10.6",
    "installed": true,
    "status": "online",
    "address": "https://<localurl>",
    "httpsForced": "1",
    "httpsSelfsigned": "1",
    "hiddenService": "<onionurl>.onion",
    "authMethod": "none",
    "details": {},
    "error": ""
  },

@cstenglein cstenglein assigned rootzoll and unassigned cstenglein Jul 29, 2023
@rootzoll
Copy link
Collaborator

@cstenglein I dont see redis in play here. For me this looks like the WebUI is creating the wrong url formatting in the end.

The way it goes is: The API calls the script bonus.lnbits.sh status takes the toraddress from there and gives it out as the hiddenService for the lnbits app. And in your example above this looks correct. But when calling the WebUI thru TorBrowser with the WebUI-Onion, then going to the APP section and wanna opening lnbits - I also see a https://{raspiublitz_url}.onion/{lnbits_url}.onion style address which does not work.

@rootzoll
Copy link
Collaborator

@cstenglein BTW it seems to be the same for all apps (not just lnbits) when the WebUI running in TorBrowser that the "OPEN" link has that malforme.

@cstenglein cstenglein added this to the 1.2.0 milestone Aug 1, 2023
@cstenglein
Copy link
Collaborator

@rootzoll thank you for clarifying, looks like I didn't understand the issue at first.

Got a fix ready, will push soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check Issues to be read / refined
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants