diff --git a/drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c b/drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c index 6ea526106fcd4e..555ff54c84060f 100644 --- a/drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c +++ b/drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c @@ -733,9 +733,10 @@ void mgt_dispatcher(_adapter *padapter, union recv_frame *precv_frame) case WIFI_AUTH: if(check_fwstate(pmlmepriv, WIFI_AP_STATE) == _TRUE) ptable->func = &OnAuth; + /* falls through */ else ptable->func = &OnAuthClient; - //pass through + /* falls through */ case WIFI_ASSOCREQ: case WIFI_REASSOCREQ: _mgt_dispatcher(padapter, ptable, precv_frame); diff --git a/drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c b/drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c index 2df28ba35427ef..26b1d0e0f8f33e 100644 --- a/drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c +++ b/drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c @@ -1477,7 +1477,7 @@ _func_enter_; bitwise_xor(aes_out, mic_header2, chain_buffer); aes128k128d(key, chain_buffer, aes_out); - for (i = 0; i < num_blocks; i++) + for (i = 0; i < num_blocks; i++) { bitwise_xor(aes_out, &pframe[payload_index], chain_buffer);//bitwise_xor(aes_out, &message[payload_index], chain_buffer); @@ -1504,8 +1504,8 @@ _func_enter_; for (j = 0; j < 8; j++) pframe[payload_index+j] = mic[j]; //message[payload_index+j] = mic[j]; - payload_index = hdrlen + 8; - for (i=0; i< num_blocks; i++) + payload_index = hdrlen + 8; + for (i=0; i< num_blocks; i++) { construct_ctr_preload( ctr_preload, @@ -1878,8 +1878,8 @@ _func_enter_; for (j = 0; j < 8; j++) message[payload_index+j] = mic[j]; - payload_index = hdrlen + 8; - for (i=0; i< num_blocks; i++) + payload_index = hdrlen + 8; + for (i=0; i< num_blocks; i++) { construct_ctr_preload( ctr_preload, diff --git a/drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/rtl8192c_phycfg.c b/drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/rtl8192c_phycfg.c index 8b19cedede1687..af6a49bca3aafb 100644 --- a/drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/rtl8192c_phycfg.c +++ b/drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/rtl8192c_phycfg.c @@ -2363,6 +2363,7 @@ phy_TxPwrIdxToDbm( case WIRELESS_MODE_G: case WIRELESS_MODE_N_24G: Offset = -8; + break; default: Offset = -8; break; diff --git a/drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/usb/usb_halinit.c b/drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/usb/usb_halinit.c index edb72c14ef1feb..72d5bc82d2d5b6 100644 --- a/drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/usb/usb_halinit.c +++ b/drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/usb/usb_halinit.c @@ -5692,6 +5692,7 @@ _func_enter_; { case HW_VAR_BASIC_RATE: *((u16 *)(val)) = pHalData->BasicRateSet; + /* falls through */ case HW_VAR_TXPAUSE: val[0] = rtw_read8(Adapter, REG_TXPAUSE); break; diff --git a/drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c b/drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c index b131a496f95a9a..f7a9c01b6c3018 100644 --- a/drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c +++ b/drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c @@ -820,6 +820,7 @@ static int set_group_key(_adapter *padapter, u8 *key, u8 alg, int keyid) case _TKIP_WTMIC_: case _AES_: keylen = 16; + break; default: keylen = 16; } diff --git a/drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_linux.c b/drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_linux.c index 1413b27edeee87..2af84222d0b04f 100644 --- a/drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_linux.c +++ b/drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_linux.c @@ -7381,6 +7381,7 @@ static int set_group_key(_adapter *padapter, u8 *key, u8 alg, int keyid) case _TKIP_WTMIC_: case _AES_: keylen = 16; + break; default: keylen = 16; } diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index e4bad872b7e547..fe99c96fc6fcda 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1732,7 +1732,6 @@ vchiq_open(struct inode *inode, struct file *file) vchiq_log_info(vchiq_arm_log_level, "vchiq_open"); switch (dev) { case VCHIQ_MINOR: { - int ret; VCHIQ_STATE_T *state = vchiq_get_state(); VCHIQ_INSTANCE_T instance; diff --git a/drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c b/drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c index ec804c7cd06d2d..ca362db1602aa9 100644 --- a/drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c +++ b/drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c @@ -591,8 +591,8 @@ static int notrace noinline fiq_fsm_update_hs_isoc(struct fiq_state *state, int } } else { - switch (st->hcchar_copy.b.multicnt) { st->hctsiz_copy.b.xfersize = nrpackets * st->hcchar_copy.b.mps; + switch (st->hcchar_copy.b.multicnt) { case 1: st->hctsiz_copy.b.pid = DWC_PID_DATA0; break; diff --git a/sound/soc/bcm/allo-piano-dac-plus.c b/sound/soc/bcm/allo-piano-dac-plus.c index d1ac0494967fb0..bede9bdec3c715 100644 --- a/sound/soc/bcm/allo-piano-dac-plus.c +++ b/sound/soc/bcm/allo-piano-dac-plus.c @@ -704,11 +704,10 @@ static int snd_allo_piano_dac_init(struct snd_soc_pcm_runtime *rtd) struct snd_soc_card *card = rtd->card; struct glb_pool *glb_ptr; - glb_ptr = kmalloc(sizeof(struct glb_pool), GFP_KERNEL); + glb_ptr = kzalloc(sizeof(struct glb_pool), GFP_KERNEL); if (!glb_ptr) return -ENOMEM; - memset(glb_ptr, 0x00, sizeof(glb_ptr)); card->drvdata = glb_ptr; glb_ptr->dual_mode = 2; glb_ptr->set_mode = 0;