TPM Module SLB9670 fails to function after RPiOS upgrade

[adam-burns]

Describe the bug

tpm2 hardware appears to be no longer correctly recognised/initialised by DT overlay and kernel modules, and tpm2 tools timeout and fail.

To reproduce

Upgrade RPiOS from 5.4.* to 5.10.17

Expected behaviour
tpm2 functions to continue to function as per before kernel/raspberry os upgrade.

Actual behaviour
After upgrade to new kernel and os version, tpm2 tools cease to correctly function.

root@raspberrypi:~# tpm2_getrandom 10

** (process:621): CRITICAL **: 15:10:24.436: failed to allocate dbus proxy object: Error calling StartServiceByName for com.intel.tss2.Tabrmd: Timeout was reached
ERROR: tcti init allocation routine failed for library: "tabrmd" options: "(null)"
ERROR: Could not load tcti, got: "tabrmd"

System

• Which model of Raspberry Pi? e.g. Pi3B+, PiZeroW
  PiZeroW

• Which OS and version (cat /etc/rpi-issue)?
  Raspberry Pi reference 2021-01-11
  Generated using pi-gen, https://github.com/RPi-Distro/pi-gen, 21090519d85bdaa1615d5d5057d37b09368ea5d2, stage2

• Which firmware version (vcgencmd version)?
  Feb 25 2021 12:12:09
  Copyright (c) 2012 Broadcom
  version 564e5f9b852b23a330b1764bcf0b2d022a20afd0 (clean) (release) (start)

• Which kernel version (uname -a)?
  Linux raspberrypi 5.10.17+ vchiq_arm: do not use page_cache_release(page) macro #1403 Mon Feb 22 11:26:13 GMT 2021 armv6l GNU/Linux

Logs
If applicable, add the relevant output from dmesg or similar.

[ 38.462389] tpm_tis_spi spi0.1: 2.0 TPM (device-id 0x1B, rev-id 22)
[ 38.505030] tpm tpm0: A TPM error (256) occurred attempting the self test
[ 38.505093] tpm tpm0: starting up the TPM manually

Additional context

I suspect this may be related to another issue

https://www.raspberrypi.org/forums/viewtopic.php?f=75&t=303564&p=1817702#p1817702

[adam-burns]

The issue has disappeared and the TPM2 tools functions correctly when recreating the image with the following:

• Which firmware version (vcgencmd version)?
  Apr 12 2021 15:54:06
  Copyright (c) 2012 Broadcom
  version 0227a0840ee8c94294cf3b2c4b2d42031a58f05a (clean) (release) (start)

• Which kernel version (uname -a)?
  Linux raspberrypi 5.10.27 var->green.length may be left uninitialized #1 Fri Apr 16 07:37:54 CEST 2021 armv6l GNU/Linux