Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ATO-2131] Instrument ActionExecutor._create_api_response #1076

Merged
merged 5 commits into from
Feb 16, 2024
Merged

[ATO-2131] Instrument ActionExecutor._create_api_response #1076

merged 5 commits into from
Feb 16, 2024

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Feb 15, 2024 •
edited
Loading

Proposed changes:

Views from Jaegar UI
Screenshot 2024-02-15 at 17 49 47
Screenshot 2024-02-15 at 18 18 11

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt force-pushed the ATO-2131-instrument-ActionExecutor._create_api_response branch 2 times, most recently from 05e95dc to 24fa884 Compare February 15, 2024 11:19
@Tawakalt Tawakalt force-pushed the ATO-2131-instrument-ActionExecutor._create_api_response branch from 24fa884 to 85dcf9b Compare February 15, 2024 11:29
@Tawakalt Tawakalt force-pushed the ATO-2131-instrument-ActionExecutor._create_api_response branch from 9754c92 to 005cfa0 Compare February 15, 2024 17:21
@Tawakalt
Copy link
Contributor Author

Update at 005cfa0
Updated JaegarUI screenshots as well.

ancalita
ancalita reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more touch-up comments 👍🏻

rasa_sdk/tracing/instrumentation/attribute_extractors.py Show resolved Hide resolved
changelog/1076.improvement.md Outdated Show resolved Hide resolved
tests/tracing/instrumentation/test_action_executor.py Outdated Show resolved Hide resolved
ancalita
ancalita approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

tests/tracing/instrumentation/test_action_executor.py Outdated Show resolved Hide resolved
@Tawakalt Tawakalt force-pushed the ATO-2131-instrument-ActionExecutor._create_api_response branch from 620f59f to 32c3b23 Compare February 16, 2024 11:11
@Tawakalt Tawakalt merged commit 2f3b8b7 into main Feb 16, 2024
16 checks passed
@Tawakalt Tawakalt deleted the ATO-2131-instrument-ActionExecutor._create_api_response branch February 16, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tawakalt @ancalita