[ATO-1661] Add --endpoints flag to rasa-sdk cli
#1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tawakalt
force-pushed
the
ATO-1661-add-endpoints-arg-to-rasa-sdk-cli
branch
from
f80680b
to
c928e65
Compare
ancalita
reviewed
Feb 5, 2024
rasa_sdk/cli/arguments.py
Outdated
| parser.add_argument( | ||
| "--endpoints", | ||
| default=DEFAULT_ENDPOINTS_PATH, | ||
| help="Configuration file for tracing as a yml file.", |
There was a problem hiding this comment.
Minor comment: I expect the assistant endpoints file would be used which contains more details than just tracing config. I'd rephrase this to reflect that, unless you recommend separating the tracing config in a diff config file, in which case we should rename the arg?
ancalita
approved these changes
Feb 5, 2024
tests/test_arguments.py
Outdated
| import rasa_sdk.endpoint as ep | ||
|
|
||
|
|
||
| def test_arg_parser_endpoints(): |
There was a problem hiding this comment.
Final comment: can we parametrize this test so that it checks for default in one test, and for the specified param in another case?
Tawakalt
force-pushed
the
ATO-1661-add-endpoints-arg-to-rasa-sdk-cli
branch
from
66e7a0d
to
e9d7183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)