Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to rename speech_detection to speech_recognition #234

Open
alexge233 opened this issue Jan 31, 2016 · 3 comments
Open

Suggestion to rename speech_detection to speech_recognition #234

alexge233 opened this issue Jan 31, 2016 · 3 comments

Comments

@alexge233
Copy link
Contributor

I would suggest we rename speech_detection_google and speech_detection_sphinx to speech_recognition_X.

The term speech_detection implies we're detecting speech, as in diarization which is a feature I would like to implement either locally in the API, or as a Service. It's purpose is to detect audio speech within audio files, whereas the Google and Sphinx4 API are recognizing speech as text.

@etsardou
Copy link
Member

etsardou commented Feb 1, 2016

Indeed, you are right. If you plan to implement this in the near future, instead of speech detection use the more appropriate term voice activity detection.

We will plan this change for the 0.7 release.

@etsardou etsardou added this to the v0.7 milestone Feb 1, 2016
@alexge233
Copy link
Contributor Author

How about diarization which is the keyword normally used?
I've found shout which is a continuous diarization written in C++ as somebody's PhD research.

@etsardou
Copy link
Member

etsardou commented Feb 3, 2016

Sure, as you prefer.

@etsardou etsardou modified the milestones: FutureWork, v0.7 Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants