Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions for cpp build #119

Open
rkooo567 opened this issue Nov 7, 2023 · 4 comments
Open

Questions for cpp build #119

rkooo567 opened this issue Nov 7, 2023 · 4 comments

Comments

@rkooo567
Copy link

rkooo567 commented Nov 7, 2023

Is it necessary to create the conda env if I just would like to build cpp code (I don't need python binding)? If not, is it possible to educate me what's the minimal set of dependencies I need to build cpp part of ucxx?

@rkooo567
Copy link
Author

rkooo567 commented Nov 7, 2023

Hmm actually also when I just followed the initial instruction;

create conda env (all_cuda118 one) ->

./build.sh libucxx benchmarks tests examples -v 

I am facing

CMake Error at /home/ray/anaconda3/envs/ucxx/lib/cmake/rmm/rmm-config.cmake:157 (thrust_create_target):
  Unknown CMake command "thrust_create_target".
Call Stack (most recent call first):
  build/cmake/CPM_0.38.5.cmake:243 (find_package)
  build/cmake/CPM_0.38.5.cmake:303 (cpm_find_package)
  build/_deps/rapids-cmake-src/rapids-cmake/cpm/find.cmake:176 (CPMFindPackage)
  build/_deps/rapids-cmake-src/rapids-cmake/cpm/rmm.cmake:75 (rapids_cpm_find)
  cmake/thirdparty/get_rmm.cmake:20 (rapids_cpm_rmm)
  cmake/thirdparty/get_rmm.cmake:24 (find_and_configure_rmm)
  CMakeLists.txt:97 (include)

(which is confusing because I didn't specify we need RMM)?

Have you seen a similar issue before? Or does it require me to have cuda 118 downloaded? (I used all_cuda-118_arch-x86_64)

Edit
It seems to work when I have cu118

@pentschev
Copy link
Member

Is it necessary to create the conda env if I just would like to build cpp code (I don't need python binding)? If not, is it possible to educate me what's the minimal set of dependencies I need to build cpp part of ucxx?

It shouldn't be necessary to have conda at all, but currently we're mostly testing with those environments. It's indeed an oversight that we don't have minimal environment files for C++ and Python, I'm adding those now via #120. Could you please try the cpp.yaml one on your end? That should suffice for C++ builds.

Edit
It seems to work when I have cu118

Would you mind retrying with cpp.yaml? RMM shouldn't be necessary and at least on my end it compiled without problems even if I don't have RMM available, as it should be.

@rkooo567
Copy link
Author

rkooo567 commented Nov 7, 2023

that's awesome! I will try the PR asap today!

@rkooo567
Copy link
Author

rkooo567 commented Nov 8, 2023

It seems to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants