From 87d1878f8096e434b241a163a556a51f13c61461 Mon Sep 17 00:00:00 2001 From: Hyunsu Cho Date: Mon, 7 Jun 2021 15:54:53 -0700 Subject: [PATCH 1/2] Update build instruction in README --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 586529711..a039fda72 100644 --- a/README.md +++ b/README.md @@ -76,15 +76,15 @@ $ git clone --recurse-submodules https://github.com/rapidsai/rmm.git $ cd rmm ``` -Follow the instructions under "Create the conda development environment `cudf_dev`" in the +Follow the instructions under "Create the conda development environment `rmm_dev`" in the [cuDF README](https://github.com/rapidsai/cudf#build-from-source). -- Create the conda development environment `cudf_dev` +- Create the conda development environment `rmm_dev` ```bash # create the conda environment (assuming in base `cudf` directory) -$ conda env create --name cudf_dev --file conda/environments/dev_py35.yml +$ conda env create --name rmm_dev --file conda/environments/rmm_dev_cuda11.0.yml # activate the environment -$ source activate cudf_dev +$ conda activate rmm_dev ``` - Build and install `librmm` using cmake & make. CMake depends on the `nvcc` executable being on From fde5b91879b586ee162b004bb1f60e8e7c16e9ae Mon Sep 17 00:00:00 2001 From: Hyunsu Cho Date: Tue, 20 Jul 2021 15:15:30 -0700 Subject: [PATCH 2/2] Address reviewer's feedback --- README.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/README.md b/README.md index a039fda72..ec2f7b91c 100644 --- a/README.md +++ b/README.md @@ -76,12 +76,9 @@ $ git clone --recurse-submodules https://github.com/rapidsai/rmm.git $ cd rmm ``` -Follow the instructions under "Create the conda development environment `rmm_dev`" in the -[cuDF README](https://github.com/rapidsai/cudf#build-from-source). - - Create the conda development environment `rmm_dev` ```bash -# create the conda environment (assuming in base `cudf` directory) +# create the conda environment (assuming in base `rmm` directory) $ conda env create --name rmm_dev --file conda/environments/rmm_dev_cuda11.0.yml # activate the environment $ conda activate rmm_dev