From 08b0827f76148dc75dc51793b70e2549604aeb93 Mon Sep 17 00:00:00 2001 From: Mike Wilson Date: Mon, 17 Jul 2023 23:19:52 +0000 Subject: [PATCH 1/2] Adding identify minimum version --- conda/environments/all_cuda-118_arch-x86_64.yaml | 1 + conda/environments/all_cuda-120_arch-x86_64.yaml | 1 + dependencies.yaml | 1 + 3 files changed, 3 insertions(+) diff --git a/conda/environments/all_cuda-118_arch-x86_64.yaml b/conda/environments/all_cuda-118_arch-x86_64.yaml index 36c3573d7..f668c4a4c 100644 --- a/conda/environments/all_cuda-118_arch-x86_64.yaml +++ b/conda/environments/all_cuda-118_arch-x86_64.yaml @@ -11,6 +11,7 @@ dependencies: - cython>=0.29,<0.30 - fmt>=9.1.0,<10 - gcovr>=5.0 +- identify>=2.5.20 - ninja - numba>=0.57 - numpy>=1.21 diff --git a/conda/environments/all_cuda-120_arch-x86_64.yaml b/conda/environments/all_cuda-120_arch-x86_64.yaml index ebbdc7758..40291ba33 100644 --- a/conda/environments/all_cuda-120_arch-x86_64.yaml +++ b/conda/environments/all_cuda-120_arch-x86_64.yaml @@ -11,6 +11,7 @@ dependencies: - cython>=0.29,<0.30 - fmt>=9.1.0,<10 - gcovr>=5.0 +- identify>=2.5.20 - ninja - numba>=0.57 - numpy>=1.21 diff --git a/dependencies.yaml b/dependencies.yaml index 6085088df..1fa7e83cc 100644 --- a/dependencies.yaml +++ b/dependencies.yaml @@ -107,6 +107,7 @@ dependencies: - output_types: [conda, requirements] packages: - pre-commit + - identify>=2.5.20 cudatoolkit: specific: - output_types: conda From a5dc21990d31ad7e00a3007cc060036a60a75c32 Mon Sep 17 00:00:00 2001 From: Mike Wilson Date: Tue, 18 Jul 2023 19:09:52 +0000 Subject: [PATCH 2/2] adding comments --- dependencies.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dependencies.yaml b/dependencies.yaml index 1fa7e83cc..91eed8280 100644 --- a/dependencies.yaml +++ b/dependencies.yaml @@ -107,6 +107,8 @@ dependencies: - output_types: [conda, requirements] packages: - pre-commit + # pre-commit requires identify minimum version 1.0, but clang-format requires textproto support and that was + # added in 2.5.20, so we need to call out the minimum version needed for our plugins - identify>=2.5.20 cudatoolkit: specific: