Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RMM CI should not only test PTDS mode #555

Closed
harrism opened this issue Sep 14, 2020 · 1 comment
Closed

[BUG] RMM CI should not only test PTDS mode #555

harrism opened this issue Sep 14, 2020 · 1 comment
Labels
bug Something isn't working gpuCI Python Related to RMM Python API tests Related to unit tests

Comments

@harrism
Copy link
Member

harrism commented Sep 14, 2020

Recently a decision was made to build and test cuDF with Per-Thread Default Stream set to ON, because this is a more conservative test than OFF and therefore it should be sufficient to test cuDF only with PTDS ON.

However, for some reason that change was also applied to RMM which is NOT a valid testing approach since unlike cuDF, RMM has separate code paths for PTDS=ON and PTDS=OFF. If we only test with PTDS ON, then we will not be testing both paths.

Instead, librmm includes CMake code to compile some of its tests in both modes, creating separate PTDS and non-PTDS test binaries. So for C++ / gtesting, PTDS should not be globally configured for RMM.

For Python testing, we need to change to building the Cython bindings twice (once with PTDS=ON and once with PTDS=OFF) and run the pytests twice.

@harrism
Copy link
Member Author

harrism commented Oct 19, 2020

Fixed by #603

@harrism harrism closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpuCI Python Related to RMM Python API tests Related to unit tests
Projects
None yet
Development

No branches or pull requests

1 participant