Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Remove deprecated rmm._lib #1762

Closed
bdice opened this issue Dec 11, 2024 · 1 comment · Fixed by #1765
Closed

[FEA] Remove deprecated rmm._lib #1762

bdice opened this issue Dec 11, 2024 · 1 comment · Fixed by #1765
Assignees
@Matt711
Labels
feature request New feature or request

Comments

@bdice
Copy link
Contributor

bdice commented Dec 11, 2024 •
edited
Loading

We recently refactored rmm._lib to rmm.librmm and rmm.pylibrmm, see #1713 and #1676. We deprecated rmm._lib in 24.12, so we can remove rmm._lib in 25.02.

We will need to audit RAPIDS for uses of this private rmm._lib prior to removal but those should be straightforward fixes to imports.

Audit via GitHub search: https://github.com/search?q=org%3Arapidsai%20%22rmm._lib%22&type=code
@bdice bdice added the feature request New feature or request label Dec 11, 2024
@bdice
Copy link
Contributor Author

bdice commented Dec 11, 2024

See also:

rmm/python/rmm/rmm/tests/test_rmm.py

Line 1083 in 73a66c9

# TODO: Remove test when rmm._lib is removed in 25.02

@Matt711 Matt711 self-assigned this Dec 11, 2024
@Matt711 Matt711 mentioned this issue Dec 13, 2024
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in bf606ef Dec 14, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in RMM Project Board Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matt711 Matt711

Labels
feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove rmm._lib Matt711/rmm
2 participants
@bdice @Matt711