Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Consistently define equality test for adaptors #1619

Closed
vyasr opened this issue Jul 19, 2024 · 3 comments
Closed

[BUG] Consistently define equality test for adaptors #1619

vyasr opened this issue Jul 19, 2024 · 3 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@vyasr
Copy link
Contributor

vyasr commented Jul 19, 2024

Describe the bug
While reviewing https://github.com/rapidsai/cudf/pull/16187/files, I noticed a change to how equals is defined for the stream checking mr. This rang a bell, so I looked for similar behavior in rmm. We turn out to be a bit inconsistent in whether adaptors can be considered equal if their upstreams are equal even if the adaptors themselves are not. I don't think it's terribly important to be able to perform this comparison, so it's not surprising that nobody has reported any issues here yet, but we should aim to make sure that we're making the same decision everywhere.

@vyasr vyasr added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jul 19, 2024
@harrism
Copy link
Member

harrism commented Jul 22, 2024

Unless cuda::mr namespace adds a concept for adaptors, then we will have to change the semantics of equality completely anyway. See https://github.com/orgs/rapidsai/projects/60?pane=issue&itemId=46738196

@vyasr
Copy link
Contributor Author

vyasr commented Jul 22, 2024

Feel free to close this issue if you'd prefer to just track in #1402

@harrism
Copy link
Member

harrism commented Jul 22, 2024

Good idea, let's track in #1402.

@harrism harrism closed this as completed Jul 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in RMM Project Board Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants