You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
While reviewing https://github.com/rapidsai/cudf/pull/16187/files, I noticed a change to how equals is defined for the stream checking mr. This rang a bell, so I looked for similar behavior in rmm. We turn out to be a bit inconsistent in whether adaptors can be considered equal if their upstreams are equal even if the adaptors themselves are not. I don't think it's terribly important to be able to perform this comparison, so it's not surprising that nobody has reported any issues here yet, but we should aim to make sure that we're making the same decision everywhere.
The text was updated successfully, but these errors were encountered:
Describe the bug
While reviewing https://github.com/rapidsai/cudf/pull/16187/files, I noticed a change to how
equals
is defined for the stream checking mr. This rang a bell, so I looked for similar behavior in rmm. We turn out to be a bit inconsistent in whether adaptors can be considered equal if their upstreams are equal even if the adaptors themselves are not. I don't think it's terribly important to be able to perform this comparison, so it's not surprising that nobody has reported any issues here yet, but we should aim to make sure that we're making the same decision everywhere.The text was updated successfully, but these errors were encountered: