Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] librmm 22.10 and 22.12 conda packages ship spdlog as part of the package #1205

Closed
kkraus14 opened this issue Feb 8, 2023 · 3 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@kkraus14
Copy link
Contributor

kkraus14 commented Feb 8, 2023

Describe the bug

The 22.10 and 22.12 librmm conda packages in the rapidsai channel ship a libspdlog.a static library as well as the spdlog headers, cmake files, and pkgconfig file. I only checked the x86_64 packages, but I assume aarch64 is the same.

Expected behavior

The conda packages shouldn't ship spdlog in any way and should leverage their spdlog dependency to get the needed pieces.

@kkraus14 kkraus14 added ? - Needs Triage Need team to review and classify bug Something isn't working labels Feb 8, 2023
@vyasr
Copy link
Contributor

vyasr commented Feb 16, 2023

This is resolved by #1177, right @bdice? I'm assuming that this was happening because of the preexisting mismatch between the conda-forge spdlog pinning and the version we were using, which should now be aligned after #1177.

@bdice
Copy link
Contributor

bdice commented Feb 16, 2023

I think #1177 solves this, yes. I looked at the package contents and didn’t see any packaged headers. Resolving - feel free to reopen if needed.

@bdice bdice closed this as completed Feb 16, 2023
@vyasr
Copy link
Contributor

vyasr commented Feb 16, 2023

Yup I checked the recent packages as well and didn't find any spdlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants