From f2d079768215357953ab87227139167cd2beb95c Mon Sep 17 00:00:00 2001 From: Mark Harris <783069+harrism@users.noreply.github.com> Date: Thu, 13 Jun 2024 20:13:17 +1000 Subject: [PATCH] Remove THRUST_WRAPPED_NAMESPACE and tests (#1578) Fixes #1577. Removes the no-longer-necessary duplications of tests for `THRUST_WRAPPED_NAMESPACE` Wrapping the Thrust namespace is no longer required as of CCCL 2.3 (but is still available if needed). RMM is adopting CCCL 2.5 in release 24.08. Eliminating these tests improves build time and reduces testing time by 50%. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Lawrence Mitchell (https://github.com/wence-) - Bradley Dice (https://github.com/bdice) - Michael Schellenberger Costa (https://github.com/miscco) URL: https://github.com/rapidsai/rmm/pull/1578 --- tests/CMakeLists.txt | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 31410566a..b9285df3c 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -104,11 +104,6 @@ function(ConfigureTest TEST_NAME) ConfigureTestInternal("${PTDS_TEST_NAME}" ${_RMM_TEST_UNPARSED_ARGUMENTS}) target_compile_definitions("${PTDS_TEST_NAME}" PUBLIC CUDA_API_PER_THREAD_DEFAULT_STREAM) - # Test with custom thrust namespace - string(REGEX REPLACE "_TEST$" "_NAMESPACE_TEST" NS_TEST_NAME "${TEST_NAME}") - ConfigureTestInternal("${NS_TEST_NAME}" ${_RMM_TEST_UNPARSED_ARGUMENTS}) - target_compile_definitions("${NS_TEST_NAME}" PUBLIC THRUST_WRAPPED_NAMESPACE=rmm_thrust) - foreach(name ${TEST_NAME} ${PTDS_TEST_NAME} ${NS_TEST_NAME}) rapids_test_add( NAME ${name}