From 4a7be093848e4240c5b6a40e2d54b3a0c2981082 Mon Sep 17 00:00:00 2001 From: Robert Maynard Date: Wed, 30 Nov 2022 07:56:42 -0500 Subject: [PATCH 1/2] Correct raft_export `GLOBAL_TARGETS` to use the exported names The raft_nn and raft_distance targets are exported with the names nn and distance, therefore those are the names that need to be marked as GLOBAL. --- cpp/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 8a006f01df..bcb8ea0214 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -673,9 +673,9 @@ raft_export( distributed GLOBAL_TARGETS raft - raft_distance + distance distributed - raft_nn + nn DOCUMENTATION doc_string NAMESPACE From b8de7b17524b43ab1946bdaa72376217f6ec67b4 Mon Sep 17 00:00:00 2001 From: Robert Maynard Date: Wed, 30 Nov 2022 09:04:59 -0500 Subject: [PATCH 2/2] Correct style issues found by CI --- cpp/CMakeLists.txt | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index bcb8ea0214..672be75df5 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -663,25 +663,8 @@ raft_export( # ################################################################################################## # * build export ------------------------------------------------------------- raft_export( - BUILD - raft - EXPORT_SET - raft-exports - COMPONENTS - nn - distance - distributed - GLOBAL_TARGETS - raft - distance - distributed - nn - DOCUMENTATION - doc_string - NAMESPACE - raft:: - FINAL_CODE_BLOCK - code_string + BUILD raft EXPORT_SET raft-exports COMPONENTS nn distance distributed GLOBAL_TARGETS raft + distance distributed nn DOCUMENTATION doc_string NAMESPACE raft:: FINAL_CODE_BLOCK code_string ) # ##################################################################################################