Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cagra filter test returns duplicate neighbor indices #2234

Open
mfoerste4 opened this issue Mar 20, 2024 · 1 comment
Open

[BUG] cagra filter test returns duplicate neighbor indices #2234

mfoerste4 opened this issue Mar 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mfoerste4
Copy link
Collaborator

Describe the bug
A new consistency check added in #2221 caused some cagra filter tests to fail. The resulting neighborhood does seem to contain duplicate neighboring ids. The effect is not limited to the #2221 branch but could also be reproduced without the changes to the IVF-flat refilter. The new check has been disabled for the cagra filter test.

Steps/Code to reproduce bug
Re-enable the check in ann_cagra.cuh and run cpp/build/gtests/NEIGHBORS_ANN_CAGRA_TEST --gtest_filter="*AnnCagraFilterTest*".

Expected behavior
The returned neighbor indices contain no duplicates for each query id.

FYI @tfeher @achirkin

@mfoerste4
Copy link
Collaborator Author

The initial occurrence is after calling into select_and_run for multi-cta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant