Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RAFT build broken by RMM change from thrust::optional to std::optional #2198

Closed
harrism opened this issue Feb 26, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working cpp

Comments

@harrism
Copy link
Member

harrism commented Feb 26, 2024

Describe the bug
RAFT build is currently broken, see e.g.
https://github.com/rapidsai/devcontainers/actions/runs/8055346951/job/22001993724#step:7:13863

This is caused by the just-merged rapidsai/rmm#1464. I was under the impression that RAPIDS repos had been searched for usage of thrust::optional with the resource types that were changed in that PR, but RAFT slipped through the cracks due to a level of indirection (I assume).

The fix is to update https://github.com/rapidsai/raft/blob/branch-24.04/cpp/include/raft/core/device_resources_manager.hpp#L115-L123 to use std::optional.

I'm working on it.

@harrism
Copy link
Member Author

harrism commented Feb 28, 2024

Fixed by #2199

@harrism harrism closed this as completed Feb 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in RMM Project Board Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp
Projects
Status: Done
Development

No branches or pull requests

1 participant