Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Re-apply the matrix::select_k heuristics #1975

Closed
achirkin opened this issue Nov 8, 2023 · 1 comment · Fixed by #1985
Closed

[ENH] Re-apply the matrix::select_k heuristics #1975

achirkin opened this issue Nov 8, 2023 · 1 comment · Fixed by #1985
Assignees
@benfred
Labels
bug Something isn't working

Comments

@achirkin
Copy link
Contributor

achirkin commented Nov 8, 2023

Re-run and apply select_k/generate_heuristic.

After #1878 is merged, the radix-based implementation should be faster than before for some inputs.
If the radix-based implementation is faster than the legacy FAISS implementation in all cases, this would be a good moment to get rid of the old code. Otherwise, we should investigate further the reasons for being slower in the remaining cases.
@achirkin achirkin added the bug Something isn't working label Nov 8, 2023
@achirkin achirkin mentioned this issue Nov 8, 2023
Merged
@achirkin achirkin mentioned this issue Nov 21, 2023
Merged
@benfred benfred linked a pull request Nov 29, 2023 that will close this issue
Update select-k heuristic #1985
Merged
@benfred benfred self-assigned this Nov 29, 2023
@benfred
Copy link
Member

benfred commented Nov 29, 2023

Done w/ #1985

@benfred benfred closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benfred benfred

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update select-k heuristic benfred/raft
2 participants
@benfred @achirkin