Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Consider removing the test for the uint32_t instance of ann_ivf_pq. #1448

Open
ahendriksen opened this issue Apr 21, 2023 · 0 comments
Open

[FEA] Consider removing the test for the uint32_t instance of ann_ivf_pq. #1448

ahendriksen opened this issue Apr 21, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@ahendriksen
Copy link
Contributor

ahendriksen commented Apr 21, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
We are currently testing the uint32_t instance of ann_ivf_pq, but we are not precompiling it in libraft.so. This slows down the compilation of the tests. Discussed here: 4426c50#r1173628831

Describe the solution you'd like
Decide whether to:

  • Add the instance to libraft.so (even if it isn't used outside the tests)
  • Remove the test
  • Add separate source files to the test to instantiate the right instances. As is done in 94d8117

Additional context
Discussion: 4426c50#r1173628831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahendriksen