Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] New brute-force API needs to support at least the metrics supported by FAISS' bfknn #1159

Closed
cjnolet opened this issue Jan 19, 2023 · 2 comments · Fixed by #1202
Closed
Assignees
Labels
FAISS feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Jan 19, 2023

It occured to me as I was reviewing rapidsai/cuml#5140 that we are going to need to support (at the very least) all the same distance measures as the FAISS bfknn in order to keep the API matching what we had before. There are several algorithms on the cuML side which rely on these additional distance measures but we will need to at least support these.

@benfred
Copy link
Member

benfred commented Feb 15, 2023

The big one that was missing was InnerProduct distance - which should be supported now with #1226 .

I've added tests for the other metrics you linked to here : it looks like BrayCurtis isn't supported by the pairwise distances API, and Jensen Shannon was producing incorrect results in the tests - but otherwise everything else is working.

@benfred
Copy link
Member

benfred commented Feb 18, 2023

JensenShannon is now being tested in the bfknn branch (code worked, but the test was failing since it was being fed negative numbers).

I created #1285 to track BrayCurtis work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FAISS feature request New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants