You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It occured to me as I was reviewing rapidsai/cuml#5140 that we are going to need to support (at the very least) all the same distance measures as the FAISS bfknn in order to keep the API matching what we had before. There are several algorithms on the cuML side which rely on these additional distance measures but we will need to at least support these.
The text was updated successfully, but these errors were encountered:
The big one that was missing was InnerProduct distance - which should be supported now with #1226 .
I've added tests for the other metrics you linked to here : it looks like BrayCurtis isn't supported by the pairwise distances API, and Jensen Shannon was producing incorrect results in the tests - but otherwise everything else is working.
It occured to me as I was reviewing rapidsai/cuml#5140 that we are going to need to support (at the very least) all the same distance measures as the FAISS bfknn in order to keep the API matching what we had before. There are several algorithms on the cuML side which rely on these additional distance measures but we will need to at least support these.
The text was updated successfully, but these errors were encountered: