Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Implement warp-collaborative binary search in sample_with_replacement_kernel #1047

Open
Nyrio opened this issue Nov 24, 2022 · 0 comments
Labels
feature request New feature or request

Comments

@Nyrio
Copy link
Contributor

Nyrio commented Nov 24, 2022

#1039 added a kernel to sample with replacement by doing a binary search on the cumulative sum of weights. However, when the number of elements to sample is very small and the range to sample from (i.e number of weights) is very large, this is not optimal. That's the case for the current use in k-means++ initialization. But this kernel only accounts for a fraction of the total execution time and is likely limited by launch latency, making this a low-priority item.

@Nyrio Nyrio added the feature request New feature or request label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant