Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on KVIKIO_COMPAT_MODE #529

Closed
kingcrimsontianyu opened this issue Oct 31, 2024 · 0 comments · Fixed by #547
Closed

Improvement on KVIKIO_COMPAT_MODE #529

kingcrimsontianyu opened this issue Oct 31, 2024 · 0 comments · Fixed by #547

Comments

@kingcrimsontianyu
Copy link
Contributor

kingcrimsontianyu commented Oct 31, 2024

Currently, there are 3 possibilities with the environment variable KVIKIO_COMPAT_MODE:

  • If it is unset, KvikIO performs a system config check [*] for GDS. If (1) the check passes and (2) if the file can be opened with O_DIRECT flag, GDS is used; otherwise, POSIX I/O is used.
  • If it is set to true, KvikIO compatibility mode is enabled, which enforces POSIX I/O, and avoids the system config check.
  • It it is set to false, KvikIO enforces GDS I/O without the system config check, and errors out on GDS operations on an incompatible config. The only exception is that if the file cannot be opened with the O_DIRECT flag, KvikIO compatibility mode will be enabled.

[*] The system config check consists of 3 parts:

  • Whether cuFile library can be correctly loaded
  • Whether /run/udev is readable
  • Whether the OS is not an WSL

Changes to the above design may be needed given the fact that:

  • CUDA 12.2 (GDS version 1.7) introduces support for non O_DIRECT. Therefore for CUDA 12.2+, when KVIKIO_COMPAT_MODE=OFF, GDS I/O path should still be taken even if the file cannot be opened with O_DIRECT. Likewise, when the env var is unset, a failure with O_DIRECT should not result in the POSIX I/O fallback.
  • KVIKIO_COMPAT_MODE=OFF expresses the users intention to choose GDS. So the O_DIRECT check can be removed.
  • It is necessary to have a separate option equivalent to the case where the env var is unset. It has been proposed that this option be named "ALLOW".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant