Ambiguous call to nvtx3::payload::payload() on macOS

[Jacobfaib]

/Users/jfaibussowit/soft/nv/legate.core.internal/arch-io/cmake_build/_deps/kvikio-src/cpp/include/kvikio/posix_io.hpp:276:3: error: call to constructor of 'nvtx3::payload' is ambiguous
  276 |   KVIKIO_NVTX_FUNC_RANGE("posix_host_read()", size);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/jfaibussowit/soft/nv/legate.core.internal/arch-io/cmake_build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp:309:18: note: expanded from macro 'KVIKIO_NVTX_FUNC_RANGE'
  308 |   GET_KVIKIO_NVTX_FUNC_RANGE_MACRO(                                  \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  309 |     __VA_ARGS__, KVIKIO_NVTX_FUNC_RANGE_2, KVIKIO_NVTX_FUNC_RANGE_1) \
      |     ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  310 |   (__VA_ARGS__)
      |   ~~~~~~~~~~~~~
/Users/jfaibussowit/soft/nv/legate.core.internal/arch-io/cmake_build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp:286:61: note: expanded from macro 'GET_KVIKIO_NVTX_FUNC_RANGE_MACRO'
  286 | #define GET_KVIKIO_NVTX_FUNC_RANGE_MACRO(_1, _2, NAME, ...) NAME
      |                                                             ^
/Users/jfaibussowit/soft/nv/legate.core.internal/arch-io/cmake_build/_deps/kvikio-src/cpp/include/kvikio/utils.hpp:283:12: note: expanded from macro 'KVIKIO_NVTX_FUNC_RANGE_2'
  283 |       msg, nvtx3::payload { val }                             \
      |            ^              ~~~~~~~

On macOS, std::size_t is unsigned long, which -- crucially -- is not std::uint64_t (unsigned long long).

Perhaps consider doing

KVIKIO_NVTX_FUNC_RANGE("posix_host_read()", std::uint64_t{size});

whenever size is std::size_t. Alternatively, the macro could be amended to do this automatically.

[madsbk]

Hmm, nvtx3::payload should have an overload for nvtx3::payload(uint32_t value).

How does the nvtx3::payload class looks like in macOS?

[Jacobfaib]

Hmm, nvtx3::payload should have an overload for nvtx3::payload(uint32_t value).

Aye, it does, but uint32_t != unsigned long != std::size_t on macOS either :), uint32_t is unsigned int.

[madsbk]

Does #474 fix it?

[Jacobfaib]

Sorry for late reply, yes it does, thank you!