New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use public API `Series.str.find_multiple`in query 18 #266

Open

bdice opened this issue Nov 16, 2022 · 0 comments

bdice commented Nov 16, 2022 •

edited

Loading

I noticed that gpu-bdb query 18 was using private methods from cudf for find_multiple:

gpu-bdb/gpu_bdb/bdb_tools/q18_utils.py

Line 21 in f48c05d

from cudf._lib.strings import find_multiple

gpu-bdb/gpu_bdb/bdb_tools/q18_utils.py

Line 127 in f48c05d

    
           cudf.Series(find_multiple.find_multiple(lowered._column, targets._column)).explode()

cudf now has public APIs that perform the same task: Series.str.find_multiple. This should be refactored to use public APIs.

See also: rapidsai/cudf#10126 (comment)

The text was updated successfully, but these errors were encountered:

bdice changed the title ~~Use Series.str.find_multiplein query 18~~ Refactor to use public API Series.str.find_multiplein query 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment