Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Highlight Additional Package Name #544

Open
nv-rliu opened this issue Sep 23, 2024 · 0 comments
Open

[FEA] Highlight Additional Package Name #544

nv-rliu opened this issue Sep 23, 2024 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@nv-rliu
Copy link
Contributor

nv-rliu commented Sep 23, 2024

Is your feature request related to a problem? Please describe.

This is a suggested feature mentioned in this thread of #536.

Highlight the Additional Package names separate from their version pinning.

Describe the solution you'd like

The following function needs to be refactored to support this feature.

if (this.active_additional_packages.length) {
    add_pkgs_ln = indentation + this.active_additional_packages
    .map(pkg => this.highlightCondaPkg(this.getAdditionalPkgName(pkg)))
        .join(" ");
}

Describe alternatives you've considered
Nothing yet. The proposed change just requires some minimal design changes.

Additional context
This was filed as a separate issue so #536 could be merged.

@nv-rliu nv-rliu added ? - Needs Triage Need team to review and classify feature request New feature or request labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant