Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support matrix entries for pyproject.toml #46

Closed
vyasr opened this issue May 12, 2023 · 2 comments
Closed

Support matrix entries for pyproject.toml #46

vyasr opened this issue May 12, 2023 · 2 comments
Assignees

Comments

@vyasr
Copy link
Contributor

vyasr commented May 12, 2023

Currently dfg explicitly prohibits matrix entries when generating pyproject.toml files. This partially makes sense: there can only ever be one pyproject.toml file at a time, so there is no value in being able to generate multiple files in one run (i.e. when dfg is run without arguments). However, there is a use case for being able to control the matrix entry used from the command line. One application of this is if we have different Python package requirements for different CUDA versions (e.g. cupy-cuda11x vs cupy-cuda12x). We would like for the packaging process to be able to leverage dfg to generate the appropriate dependency list before a package is built in this case. To support this we should allow specifying multiple matrix entries in the dependencies section even if one of the output_types is pyproject.toml. We should continue to prohibit a matrix entry in the files section, instead only generating by default the file corresponding to the default matrix entries. Note that this will require a fallback to be present for all dependency lists that specify pyproject as an output type and have a matrix section.

@bdice
Copy link
Contributor

bdice commented Jun 20, 2023

Another instance of this issue came up: rapidsai/rmm#1223 (comment)

@vyasr
Copy link
Contributor Author

vyasr commented Mar 25, 2024

This was resolved in #70

@vyasr vyasr closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants