Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow null matrix entries. #119

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 8, 2024

This PR allows null matrix entries to co-exist with non-null matrix entries.

Currently a matrix like

files:
  all:
    output: conda
    matrix:
      cuda: ["11.8", "12.5"]
      arch: [x86_64]

implies that undefined variables like py: are ignored.

With this PR, you can add a line like

files:
  all:
    output: conda
    matrix:
      cuda: ["11.8", "12.5"]
      arch: [x86_64]
      py: [null, "3.13t"]

to generate the same environments as before (where py was undefined) and additionally generate environments where py: "3.13t" is set.

I retained the naming behavior so that if a key is null, it does not appear in the environment name (we get all_cuda-125_arch-x86_64.yaml instead of all_cuda-125_arch-x86_64_py-None.yaml because I thought the py-None was an unwanted change).

An alternative to this would be to specify a different file key where the new matrix key is defined, but that would require replicating the includes: list.

@vyasr
Copy link
Contributor

vyasr commented Dec 16, 2024

@bdice is this ready for a review?

@bdice bdice changed the title Allow null matrix entries. feat: Allow null matrix entries. Dec 17, 2024
@bdice
Copy link
Contributor Author

bdice commented Dec 17, 2024

@vyasr Yes, it is ready for review.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Agree with the choice of retaining the current naming scheme.

@bdice bdice merged commit 6ee21f4 into rapidsai:main Dec 17, 2024
4 of 6 checks passed
@bdice bdice deleted the allow-null-matrix-entry branch December 17, 2024 20:23
GPUtester pushed a commit that referenced this pull request Dec 17, 2024
# [1.17.0](v1.16.0...v1.17.0) (2024-12-17)

### Features

* Allow null matrix entries. ([#119](#119)) ([6ee21f4](6ee21f4))
@GPUtester
Copy link

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants