Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update cuSpatial Readme #977

Merged
merged 9 commits into from
Mar 21, 2023

Conversation

jarmak-nv
Copy link
Contributor

@jarmak-nv jarmak-nv commented Mar 7, 2023

Description

Closes #908

With all of the development on cuSpatial, it's time for a new README that is both more up-to-date, and more aligned with other RAPIDS READMEs.

Outstanding tasks

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jarmak-nv jarmak-nv changed the title First pass update readme [DOC] Update cuSpatial Readme Mar 7, 2023
@jarmak-nv jarmak-nv self-assigned this Mar 7, 2023
[skip ci] since there's no way this is final
Add links to functions
Fix typo
Remove build from source instructions
@jarmak-nv jarmak-nv marked this pull request as ready for review March 9, 2023 16:33
@jarmak-nv jarmak-nv added non-breaking Non-breaking change doc Documentation labels Mar 9, 2023
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic improvement. Thanks! Various small suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rapids-bot bot pushed a commit that referenced this pull request Mar 20, 2023
Contributes to #908 and unblocks #977 

This PR moves the existing build from source instructions to the developer docs page. It does not make any changes to the instructions.

Authors:
  - Ben Jarmak (https://github.com/jarmak-nv)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Michael Wang (https://github.com/isVoid)

URL: #999
@jarmak-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9aa3ee2 into rapidsai:branch-23.04 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DOC]: README Update
4 participants