-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update cuSpatial Readme #977
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-23.04
from
jarmak-nv:cuspatial-readme-update
Mar 21, 2023
Merged
[DOC] Update cuSpatial Readme #977
rapids-bot
merged 9 commits into
rapidsai:branch-23.04
from
jarmak-nv:cuspatial-readme-update
Mar 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
[skip ci] since there's no way this is final Add links to functions Fix typo Remove build from source instructions
isVoid
reviewed
Mar 9, 2023
thomcom
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
harrism
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic improvement. Thanks! Various small suggestions.
Co-authored-by: Mark Harris <[email protected]>
[skip ci]
[skip ci] Co-authored-by: Mark Harris <[email protected]>
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
Contributes to #908 and unblocks #977 This PR moves the existing build from source instructions to the developer docs page. It does not make any changes to the instructions. Authors: - Ben Jarmak (https://github.com/jarmak-nv) Approvers: - H. Thomson Comer (https://github.com/thomcom) - Michael Wang (https://github.com/isVoid) URL: #999
harrism
approved these changes
Mar 20, 2023
isVoid
approved these changes
Mar 21, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #908
With all of the development on cuSpatial, it's time for a new README that is both more up-to-date, and more aligned with other RAPIDS READMEs.
Outstanding tasks
build from source
instructions to developer docsChecklist