_from_point_xy improvements
#905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix part of #888 or all of it? Please use the github syntax that will autoclose the issue if it fixes all of it. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
|
I think all of it. Adding closing terms. |
thomcom
approved these changes
Feb 8, 2023
|
lgtm, nice work |
|
@gpucibot merge |
|
@isVoid, the Please re-comment this PR with |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #888, raises when input is not an integer array.
This PR also fixes a bug in
_from_point_xywhere empty series other than points are incorrectly constructed. An empty linestring array should be properly nested with the leaf column containing 0 elements. Currently it is constructed as a flat array, resulting in a ill-constructed geocolumn.Checklist