Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept None and python list in GeoSeries constructor #686

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Accept None and python list in GeoSeries constructor #686

merged 4 commits into from
Sep 22, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Sep 21, 2022 •
edited
Loading

Description

This PR augments GeoSeries constructor with None and a python list, and punt the objects to geopandas. A test case for geoseries contructor is also added.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner September 21, 2022 19:14
@isVoid isVoid requested a review from thomcom September 21, 2022 19:14
@github-actions github-actions bot added the Python Related to Python code label Sep 21, 2022
@isVoid isVoid added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Sep 21, 2022
@thomcom
Copy link
Contributor

thomcom commented Sep 21, 2022 •
edited
Loading

Happy to approve, pass tests first?

@isVoid isVoid mentioned this pull request Sep 22, 2022
Merged
3 tasks
@thomcom
Copy link
Contributor

thomcom commented Sep 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c0ac4f5 into rapidsai:branch-22.10 Sep 22, 2022
rapids-bot bot pushed a commit that referenced this pull request Sep 29, 2022
@isVoid
Python API for point-linestring nearest points (#681)
5de8212 
This PR adds python API for point-linestring nearest points. Closes #646 .
Depend on #658 #686 

This PR also moves `Feature_Enum` from io module to geometa module to make sure the coding is consistent and reused throughout the codebase.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: #681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isVoid @thomcom