Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Enable building static libs #506

Merged
merged 3 commits into from
Apr 6, 2022
Merged

[FEA] Enable building static libs #506

merged 3 commits into from
Apr 6, 2022

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Mar 30, 2022 •
edited
Loading

This PR allows building libcuspatial static libs via CMake option -DBUILD_SHARED_LIBS=ON|OFF.

Depends on rapidsai/cudf#10545

@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 30, 2022
@trxcllnt trxcllnt requested a review from a team as a code owner March 30, 2022 20:14
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Mar 30, 2022
thomcom
thomcom approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Not sure how the cuda PR that it depends upon really fixes the problem, but I checked on the global BUILD_SHARED_LIBS CMake flag and it seems legit.

robertmaynard
robertmaynard approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harrism harrism added 5- Merge After Dependencies 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge labels Mar 31, 2022
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Apr 5, 2022

@gpucibot merge

@harrism
Copy link
Member

harrism commented Apr 6, 2022

CI still failing -- fixed by #511 ?

@trxcllnt
Copy link
Contributor Author

trxcllnt commented Apr 6, 2022

@harrism yep, looks like #511 should fix this style checker

@harrism
Copy link
Member

harrism commented Apr 6, 2022

rerun tests

@rapids-bot rapids-bot bot merged commit d94f9b4 into rapidsai:branch-22.06 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @harrism @robertmaynard @thomcom